Skip to content

Conversation

@sjvanrossum
Copy link
Contributor

The closed property is never read by the instance and its isClosed getter is never called externally. The isClosed getter would never be observed to return true since finalize is called after the VM has determined that no thread holds a strong reference to the instance.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@sjvanrossum sjvanrossum changed the title Remove unused property, assignment in finalize will not be observed [KafkaIO] Remove unused property, assignment in finalize will not be observed Oct 24, 2024
@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@johnjcasey
Copy link
Contributor

LGTM, but the checks should pass just to be sure

@sjvanrossum
Copy link
Contributor Author

Run Java PreCommit

@sjvanrossum sjvanrossum force-pushed the kafkaio-remove-finalize-update branch from 2e75392 to e1e2d9c Compare October 31, 2024 15:04
@johnjcasey johnjcasey merged commit bf2574b into apache:master Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants