Skip to content

Conversation

@sjvanrossum
Copy link
Contributor

This reverts #31137 and #31281. The changes in the former PR overwrite the per-split metric backlog_bytes.${SPLIT} with the per-partition metric rather than the accumulated value for the split. The latter PR introduced a map to store metrics for all past and current splits (1 partition) of the ReadFromKafkaDoFn instance and may repeatedly overwrite non-current splits with stale values. The map used to store these values is not thread-safe and may trigger a ConcurrentModificationException since GetSize and other SDF methods may concurrently attempt to read and write the map.

Finally, the per-split caches kept by the instance are keyed on TopicPartition, which is not unique among all splits since the split may override the bootstrap server. This has been fixed for this cache, all other caches will be patched in a separate PR.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@sjvanrossum
Copy link
Contributor Author

Run Java PreCommit

@sjvanrossum sjvanrossum force-pushed the kafkaio-split-metrics branch from 7d1a399 to b14590a Compare October 31, 2024 15:05
@johnjcasey
Copy link
Contributor

This LGTM, can you fix the conflicts?

@sjvanrossum
Copy link
Contributor Author

Done, thanks for reviewing this!

@johnjcasey
Copy link
Contributor

Can you check on the RAT test?

@sjvanrossum sjvanrossum force-pushed the kafkaio-split-metrics branch 4 times, most recently from ce8ac6e to 180f70c Compare November 12, 2024 19:24
@sjvanrossum sjvanrossum force-pushed the kafkaio-split-metrics branch from 32de1c2 to a0951af Compare November 12, 2024 20:35
@sjvanrossum
Copy link
Contributor Author

@johnjcasey rebased and updated where required. PreCommit Java Examples Dataflow seems to be failing, but passes for #32928 which is stacked on top of these changes.

@sjvanrossum
Copy link
Contributor Author

Run Java_Examples_Dataflow PreCommit

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.
R: @shunping for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn
Copy link
Contributor

Abacn commented Nov 13, 2024

Merge this as this was approved and merge conflict/test were cleared

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants