[Dataflow] Fix large commit test, move large value out of the graph #33699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
ahmedabu98
approved these changes
Jan 22, 2025
Contributor
ahmedabu98
left a comment
ahmedabu98
left a comment
There was a problem hiding this comment.
Please fix the spotless error. LGTM otherwise!
...ogle-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/LargeCommitTest.java
Outdated
Show resolved
Hide resolved
…am/runners/dataflow/LargeCommitTest.java Co-authored-by: Ahmed Abualsaud <65791736+ahmedabu98@users.noreply.github.com>
Contributor
|
Assigning reviewers. If you would like to opt out of this review, comment R: @damondouglas added as fallback since no labels match configuration Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Contributor
Author
|
This test has been flaky and running into OOMs. Test is being removed in #33745. Closing this PR for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change avoids the large values from getting serialized as part of the graph and avoids making the graph too large.