Skip to content

[Dataflow] Fix large commit test, move large value out of the graph #33699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arunpandianp wants to merge 2 commits into from
Closed

[Dataflow] Fix large commit test, move large value out of the graph #33699

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4068d3a
fix large commit test, move large value out of the graph
arunpandianp Jan 21, 2025
b869f72
Update runners/google-cloud-dataflow-java/src/test/java/org/apache/be…
arunpandianp Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 27 additions & 10 deletions ...e-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/LargeCommitTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,18 @@

import static org.hamcrest.MatcherAssert.assertThat;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;

import org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.collect.Iterables;
import java.io.Serializable;
import java.util.ArrayList;
import java.util.List;
import org.apache.beam.sdk.testing.PAssert;
import org.apache.beam.sdk.testing.TestPipeline;
import org.apache.beam.sdk.testing.ValidatesRunner;
import org.apache.beam.sdk.transforms.Create;
import org.apache.beam.sdk.transforms.DoFn;
import org.apache.beam.sdk.transforms.GroupByKey;
import org.apache.beam.sdk.transforms.ParDo;
import org.apache.beam.sdk.values.KV;
import org.apache.beam.sdk.values.PCollection;
import org.hamcrest.Matchers;
Expand All @@ -37,25 +41,38 @@
import org.junit.runners.JUnit4;

@RunWith(JUnit4.class)
public class LargeCommitTest {
public class LargeCommitTest implements Serializable {

@Rule public transient TestPipeline p = TestPipeline.create();

@Test
@Category({ValidatesRunner.class})
public void testLargeCommit() {
// 5 50MB values shuffling to a single key
String value = bigString('a', 50 << 20);
KV<String, String> kv = KV.of("a", value);
PCollection<KV<String, Iterable<String>>> result =
p.apply(Create.of(kv, kv, kv, kv, kv)).apply(GroupByKey.create());
p.apply(Create.of("starterElement"))
.apply(
ParDo.of(
new DoFn<String, KV<String, String>>() {
@ProcessElement
public void processElement(ProcessContext c) {
String value = bigString('a', 50 << 20);
KV<String, String> kv = KV.of("a", value);
// 5 50MB values shuffling to a single key
for (int i = 0; i < 5; i++) {
c.output(kv);
}
}
}))
.apply(GroupByKey.create());

PAssert.that(result)
.satisfies(
kvs -> {
assertTrue(kvs.iterator().hasNext());
KV<String, Iterable<String>> outputKV = kvs.iterator().next();
assertFalse(kvs.iterator().hasNext());
String value = bigString('a', 50 << 20);
List<KV<String, Iterable<String>>> outputKVs = new ArrayList<>();
Iterables.addAll(outputKVs, kvs);
assertEquals(1, outputKVs.size());
KV<String, Iterable<String>> outputKV = outputKVs.get(0);
assertEquals("a", outputKV.getKey());
assertThat(outputKV.getValue(), Matchers.contains(value, value, value, value, value));
return null;
Expand Down
Loading