Skip to content

Skip BoundedTrie on Dataflow till service is have BoundedTrie #33921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Abacn merged 4 commits into from
Feb 10, 2025
Merged

Skip BoundedTrie on Dataflow till service is have BoundedTrie #33921

Abacn merged 4 commits into from
Feb 10, 2025

Conversation

@rohitsinha54
Copy link
Contributor

@rohitsinha54 rohitsinha54 commented Feb 8, 2025 •
edited
Loading

Fixes #33720 #32224

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2025

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2025

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @tvalentyn added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@rohitsinha54
Copy link
Contributor Author

rohitsinha54 commented Feb 8, 2025

R: @Abacn (from context on the failure)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2025

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@Amar3tto
Copy link
Collaborator

Amar3tto commented Feb 8, 2025

Could you please also check that this PR fixes #33722 and #33723.

@github-actions github-actions bot added the build label Feb 10, 2025
@rohitsinha54
Copy link
Contributor Author

rohitsinha54 commented Feb 10, 2025

Triggered post commit workflow waiting for successful build on that to submit.

Abacn
Abacn approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, will merge after test passed

after that please open a cherry-pick PR against release-2.63 branch

@Abacn
Copy link
Contributor

Abacn commented Feb 10, 2025

Great, postcommit Java Dataflow validatesrunner passed

@Abacn Abacn merged commit e1ab2e9 into apache:master Feb 10, 2025
19 checks passed
This was referenced Feb 11, 2025
Closed
Closed
Closed
rohitsinha54 added a commit to rohitsinha54/beam that referenced this pull request Feb 11, 2025
@rohitsinha54
Skip BoundedTrie on Dataflow till service is have BoundedTrie (apache…
27130b3 
…#33921)

* Temporarily stop publishing BoundedTrie metrics till it is supported in Dataflow.

* Exclude UsesBoundedTrieMetrics from Dataflow runner

* Fix failing test

* Trivial change to postcommit to trigger it
jrmccluskey pushed a commit that referenced this pull request Feb 11, 2025
@rohitsinha54
Skip BoundedTrie on Dataflow till service is have BoundedTrie (#33921) (
a9fcaaf 
#33947)

* Temporarily stop publishing BoundedTrie metrics till it is supported in Dataflow.

* Exclude UsesBoundedTrieMetrics from Dataflow runner

* Fix failing test

* Trivial change to postcommit to trigger it
rohitsinha54 added a commit to rohitsinha54/beam that referenced this pull request Mar 14, 2025
@rohitsinha54
Revert Skip BoundedTrie on Dataflow till service is have BoundedTrie a…
c44faa5 
…pache#33921
rohitsinha54 added a commit to rohitsinha54/beam that referenced this pull request Mar 14, 2025
@rohitsinha54
Revert Skip BoundedTrie on Dataflow till service is have BoundedTrie a…
c1a4516 
…pache#33921
@rohitsinha54 rohitsinha54 mentioned this pull request Mar 14, 2025
Merged
3 tasks
robertwb added a commit that referenced this pull request Mar 19, 2025
@robertwb
Merge pull request #34294 from rohitsinha54/unskip-btrie
52a161f 
Revert Skip BoundedTrie on Dataflow till service is have BoundedTrie #33921
talatuyarer pushed a commit to talatuyarer/beam that referenced this pull request Mar 20, 2025
@rohitsinha54 @talatuyarer
Revert Skip BoundedTrie on Dataflow till service is have BoundedTrie a…
6c557fe 
…pache#33921
VardhanThigle pushed a commit to VardhanThigle/beam that referenced this pull request Mar 21, 2025
@rohitsinha54 @VardhanThigle
Skip BoundedTrie on Dataflow till service is have BoundedTrie (apache…
7ba4dd0 
…#33921)

* Temporarily stop publishing BoundedTrie metrics till it is supported in Dataflow.

* Exclude UsesBoundedTrieMetrics from Dataflow runner

* Fix failing test

* Trivial change to postcommit to trigger it
prodriguezdefino pushed a commit to prodriguezdefino/beam-pabs that referenced this pull request Mar 26, 2025
@rohitsinha54 @prodriguezdefino
Revert Skip BoundedTrie on Dataflow till service is have BoundedTrie a…
de592cb 
…pache#33921
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Abacn Abacn Abacn approved these changes

Assignees

No one assigned

Labels

build dataflow Next Action: Reviewers runners

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The PostCommit Java ValidatesRunner Dataflow V2 job is flaky

3 participants

@rohitsinha54 @Amar3tto @Abacn