-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Revert Skip BoundedTrie on Dataflow till service is have BoundedTrie … #34294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Assigning reviewers. If you would like to opt out of this review, comment R: @kennknowles added as fallback since no labels match configuration Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
R: @robertwb |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
This PR merge will start making the post submit Dataflow worker tests which exercises Dataflow runner test fails since the backend can accept BoundedTrie but cannot persist and serve it back back through MetricQuery API which the tests uses. So merge needs to be wait a little. |
|
On Dataflow side, this is blocked on: b/404336511 |
…ify metric result
|
@robertwb second commit skips running bounded trie on Dataflow runner since QM does not yet support returning it back. Although the tracking path is done so lineage testing on Bounded Trie works. |
|
R: @robertwb |
| { | ||
| "comment": "Modify this file in a trivial way to cause this test suite to run", | ||
| "modification": 1 | ||
| "modification": 2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically this is only needed to force the testing infra to think the file is changed when you have no other changes to make.
…#33921
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.