Skip to content

Conversation

@rohitsinha54
Copy link
Contributor

#33921

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@rohitsinha54
Copy link
Contributor Author

R: @robertwb

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@rohitsinha54
Copy link
Contributor Author

rohitsinha54 commented Mar 14, 2025

This PR merge will start making the post submit Dataflow worker tests which exercises Dataflow runner test fails since the backend can accept BoundedTrie but cannot persist and serve it back back through MetricQuery API which the tests uses. So merge needs to be wait a little.

@rohitsinha54
Copy link
Contributor Author

On Dataflow side, this is blocked on: b/404336511

@github-actions github-actions bot added the build label Mar 19, 2025
@rohitsinha54
Copy link
Contributor Author

@robertwb second commit skips running bounded trie on Dataflow runner since QM does not yet support returning it back. Although the tracking path is done so lineage testing on Bounded Trie works.
This PR in unblocked now and can be submitted. Also running validates_Dataflow runner post submit test on this PR.
Please help merge this PR. Thank you.

@rohitsinha54
Copy link
Contributor Author

R: @robertwb

{
"comment": "Modify this file in a trivial way to cause this test suite to run",
"modification": 1
"modification": 2,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this is only needed to force the testing infra to think the file is changed when you have no other changes to make.

@robertwb robertwb merged commit 52a161f into apache:master Mar 19, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants