-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Add an experiment named enableLineageRollup which when passed to Java… #34312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… SDK will make it report Lineage as BoundedTrie
|
R: @robertwb |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
robertwb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending getting the failing tests fixed.
| if (MetricsFlag.boundedTrieDisabled()) { | ||
| // If lineageRollupEnabled is not set explicitly then lineage is | ||
| // not emitted as BounedTrie. | ||
| if (MetricsFlag.boundedTrieDisabled() || !MetricsFlag.lineageRollupEnabled()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If !MetricsFlag.lineageRollupEnabled() we should never get here, right? I'd just omit this.
Generally it's also preferable to avoid logic that assumes nothing but lineage would ever use bounded trie.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intention was to not emit BTrie at all
https://screenshot.googleplex.com/3aUjctyjdPCueRV
But if we want "avoid logic that assumes nothing but lineage would ever use bounded trie"
Then yes removing it make sense. Done. Thanks.
|
This change has been tested by following method:
|
|
This PR depend on #34294 i.e. without the other one on legacy runner jobs cannot emit BoundedTrie so nothing gets reported. |
78eb46c to
c50e2ad
Compare
|
The tests in two failing suite seem unrelated. Earlier failures in IOs are not fixes in latest run. |
c50e2ad to
d9bf78f
Compare
d9bf78f to
927dfd3
Compare
… SDK will make it report Lineage as BoundedTrie
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.