Skip to content

Conversation

@rohitsinha54
Copy link
Contributor

… SDK will make it report Lineage as BoundedTrie

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

… SDK will make it report Lineage as BoundedTrie
@github-actions github-actions bot added the java label Mar 16, 2025
@rohitsinha54
Copy link
Contributor Author

R: @robertwb

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link
Contributor

@robertwb robertwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending getting the failing tests fixed.

if (MetricsFlag.boundedTrieDisabled()) {
// If lineageRollupEnabled is not set explicitly then lineage is
// not emitted as BounedTrie.
if (MetricsFlag.boundedTrieDisabled() || !MetricsFlag.lineageRollupEnabled()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If !MetricsFlag.lineageRollupEnabled() we should never get here, right? I'd just omit this.

Generally it's also preferable to avoid logic that assumes nothing but lineage would ever use bounded trie.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intention was to not emit BTrie at all
https://screenshot.googleplex.com/3aUjctyjdPCueRV

But if we want "avoid logic that assumes nothing but lineage would ever use bounded trie"
Then yes removing it make sense. Done. Thanks.

@rohitsinha54
Copy link
Contributor Author

This change has been tested by following method:

  1. Ran a job without using any flag on 2.64 and the Dataflow job uses StringSet for reporting lineage. Verified it through debug logs and also the type of metric reported to backend. The lineage metrics were successfully processed and sent to Dataplex as lineage graph.
  2. Passed --experiments=enableLineageRollup. Same as above. Verified that worker report lineage metrics as BoundedTrie and they were successfully reported to Dataplex as lineage graph.

@rohitsinha54
Copy link
Contributor Author

This PR depend on #34294

i.e. without the other one on legacy runner jobs cannot emit BoundedTrie so nothing gets reported.

@rohitsinha54
Copy link
Contributor Author

The tests in two failing suite seem unrelated. Earlier failures in IOs are not fixes in latest run.
@robertwb mind taking another look (third commit) and merge? I will do a force repush to trigger re-run of tests.

@robertwb robertwb merged commit d4a939e into apache:master Mar 19, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants