Add support for collections.abc.Mapping

[msuozzo]

Work towards #29135

[github-actions]

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

[github-actions]

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @tvalentyn for label python.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[msuozzo]

R: @jrmccluskey

[github-actions]

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

[msuozzo]

assign to next reviewer

[msuozzo]

assign set of reviewers

[github-actions]

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @liferoad for label python.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[jrmccluskey]

Looks like there's some duplication between this PR and #33999. Could we just combine these into a single PR? It'll save some merge conflict headaches later and reduce duplicate code review

[msuozzo]

Looks like there's some duplication between this PR and #33999. Could we just combine these into a single PR? It'll save some merge conflict headaches later and reduce duplicate code review

They're just stacked on top of each other to minimize the merge/edit headaches locally. You can view the changes specific to this PR by looking at the last commit in the chain. If GitHub ever sees the light and adds support for this, it will be a great day.

[jrmccluskey]

Realizing I really should have just merged this one after going over the first PR, but alas

[msuozzo]

Realizing I really should have just merged this one after going over the first PR, but alas

Nah I did mean them to be separate PRs. I guess it's just preference, though, since I like a 1:1 mapping for PRs and commits.

[github-actions]

Reminder, please take a look at this pr: @liferoad

[liferoad]

@jrmccluskey Ok to merge this one?

[jrmccluskey]

I'd prefer we hold this one for a little bit considering that the internal implications of the last PR are still being resolved.

[jrmccluskey]

#34254 has a few implications for this PR (mostly just hitting the same files so a merge collision can happen) along with a test case breaking by adding support for bare ordereddict types

[msuozzo]

I'll rebase onto that.

[github-actions]

Reminder, please take a look at this pr: @liferoad

[github-actions]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label python.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

[github-actions]

Reminder, please take a look at this pr: @jrmccluskey

[jrmccluskey]

LGTM, thanks!