Skip to content

Conversation

@sjvanrossum
Copy link
Contributor

@sjvanrossum sjvanrossum commented Mar 7, 2025

The fetcher (or fetch collector in later versions) in Kafka's client library already checks if a fetched record batch starts at the consumer's current position before returning any records in response to polling and otherwise ignores the batch.
See https://github.com/apache/kafka/blob/2.4.1/clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java#L675 and https://github.com/apache/kafka/blob/2.4.1/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java#L1605.

Stacked on top of #34165.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @m-trieu for label java.
R: @damccorm for label build.
R: @johnjcasey for label io.
R: @fozzie15 for label kafka.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions
Copy link
Contributor

Reminder, please take a look at this pr: @m-trieu @damccorm @johnjcasey @fozzie15

@damccorm
Copy link
Contributor

@johnjcasey @fozzie15 could you please take a look?

@sjvanrossum sjvanrossum force-pushed the kafkaio-sdf-offset-in-range branch from 275d39a to 3f172ec Compare March 14, 2025 16:19
@github-actions github-actions bot added build and removed build labels Mar 14, 2025
@sjvanrossum
Copy link
Contributor Author

@johnjcasey @fozzie15 I've rebased this PR on master instead of #34165 since there's no dependency between the two PRs.

@sjvanrossum sjvanrossum force-pushed the kafkaio-sdf-offset-in-range branch from 3f90e92 to 9709603 Compare March 18, 2025 21:55
@github-actions github-actions bot added build and removed build labels Mar 18, 2025
@sjvanrossum sjvanrossum force-pushed the kafkaio-sdf-offset-in-range branch from 1a6c16f to 07d7567 Compare March 21, 2025 13:22
@github-actions github-actions bot added build and removed build labels Mar 21, 2025
@sjvanrossum sjvanrossum force-pushed the kafkaio-sdf-offset-in-range branch from 07d7567 to a0878ba Compare March 21, 2025 13:26
@github-actions github-actions bot removed the build label Mar 21, 2025
@github-actions github-actions bot added the build label Mar 21, 2025
@chamikaramj
Copy link
Contributor

assign to next reviewer

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2025

Reminder, please take a look at this pr: @m-trieu @damccorm @johnjcasey @fozzie15

@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.
R: @Abacn for label build.
R: @johnjcasey for label io.
R: @jrmccluskey for label kafka.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@github-actions
Copy link
Contributor

Reminder, please take a look at this pr: @robertwb @Abacn @johnjcasey @jrmccluskey

@github-actions
Copy link
Contributor

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @chamikaramj for label java.
R: @damccorm for label build.
R: @johnjcasey for label io.
R: @lostluck for label kafka.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@github-actions
Copy link
Contributor

Reminder, please take a look at this pr: @chamikaramj @damccorm @johnjcasey @lostluck

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2025

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @ahmedabu98 for label java.
R: @Abacn for label build.
R: @johnjcasey for label io.
R: @robertwb for label kafka.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@github-actions
Copy link
Contributor

Reminder, please take a look at this pr: @ahmedabu98 @Abacn @johnjcasey @robertwb

@github-actions
Copy link
Contributor

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @chamikaramj for label java.
R: @damccorm for label build.
R: @johnjcasey for label io.
R: @tvalentyn for label kafka.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@tvalentyn
Copy link
Contributor

stop reviewer notifications

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: requested by reviewer. If you'd like to restart, comment assign set of reviewers

@github-actions github-actions bot removed the build label May 19, 2025
@scwhittle
Copy link
Contributor

Failure looks unrelated, merging.

@scwhittle scwhittle merged commit 0f4f98d into apache:master May 19, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants