-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[KafkaIO] Update tracker and watermark for non-visible progress #34202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KafkaIO] Update tracker and watermark for non-visible progress #34202
Conversation
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
a3cbc4f to
bf7e2d2
Compare
|
Run Java_Kafka_IO_Direct PreCommit |
d10f1a4 to
5da4e7f
Compare
5da4e7f to
f81486e
Compare
|
Assigning reviewers. If you would like to opt out of this review, comment R: @robertwb for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Any updates ? |
|
@robertwb @ahmedabu98 or @johnjcasey PTAL. |
|
LGTM |
|
Reminder, please take a look at this pr: @robertwb @ahmedabu98 @johnjcasey |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @kennknowles for label java. Available commands:
|
|
Hey @sjvanrossum, are you still working on this? do you need another review? |
|
@ahmedabu98 this is good to go, just needs another review. :) |
|
Latest code changes seem to have LGTM from John. Just needs merge. |
|
The commit descriptions look like they should be kept separate. Is that correct? |
|
@kennknowles the second commit addresses an isolated issue (expected offset does not advance on the error handling path), but it only surfaced as a problem with the changes in the first commit of this PR. |
* Improve caching in backlog estimation and processing * Add comment to explain the behavior of volatile guard field in KafkaLatestOffsetEstimator * Guard against exceptions in endOffset refresh * Call cancelIfTimeouted in roundtripElements to shutdown lingering pipelines * Add missing calls to seek and/or pause before return points added in #34202
Calls to poll have timed out if ConsumerRecords.empty() is (by reference) equal to the result of poll.
All other instances may have non-visible records at the end of a batch which should be skipped over while still claiming up to the next offset and updating the watermark.
Stacked on top of #34201.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.