[AnomalyDetection] Refactor and improve Specifiable #34310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
r: @damccorm |
shunping
changed the title
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
shunping
force-pushed
the
anomaly-detection-6
branch
from
9bba3ef to
3af3cb7
Compare
- Better typehinting in specifiable with overloads - Move non-method attributes and staticmethod outside of Specifiable Protocol - Make spec_type a function which returns a class-specific spec_type variable - Add tests for some uncommon use cases.
shunping
force-pushed
the
anomaly-detection-6
branch
from
3af3cb7 to
9085dfa
Compare
shunping
changed the title
This was referenced Mar 17, 2025
damccorm
reviewed
Mar 17, 2025
shunping
force-pushed
the
anomaly-detection-6
branch
from
679dd22 to
aa4ae03
Compare
damccorm
reviewed
Mar 18, 2025
Contributor
damccorm
left a comment
damccorm
left a comment
There was a problem hiding this comment.
Just had one more comment, otherwise this LGTM
Contributor
|
Waiting on checks to pass then will merge |
damccorm
approved these changes
Mar 18, 2025
Contributor
damccorm
left a comment
damccorm
left a comment
There was a problem hiding this comment.
Test failure is unrelated
talatuyarer
pushed a commit
to talatuyarer/beam
that referenced
this pull request
Mar 20, 2025
* Refactor and improve Specifiable. - Better typehinting in specifiable with overloads - Move non-method attributes and staticmethod outside of Specifiable Protocol - Make spec_type a function which returns a class-specific spec_type variable - Add tests for some uncommon use cases. * Fix static function names and use pass for empty functions per review. * Add a warning for unsupported types in spec.
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.