Skip to content

Conversation

@shunping
Copy link
Collaborator

@shunping shunping commented Mar 15, 2025

Depends on #34310

@codecov
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

Attention: Patch coverage is 92.59259% with 8 lines in your changes missing coverage. Please review.

Project coverage is 56.36%. Comparing base (5950a17) to head (57a3381).
Report is 21 commits behind head on master.

Files with missing lines Patch % Lines
sdks/python/apache_beam/ml/anomaly/specifiable.py 93.65% 4 Missing ⚠️
...python/apache_beam/ml/anomaly/detectors/offline.py 88.88% 2 Missing ⚠️
sdks/python/apache_beam/ml/anomaly/transforms.py 92.30% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #34311      +/-   ##
============================================
+ Coverage     56.34%   56.36%   +0.02%     
  Complexity     3286     3286              
============================================
  Files          1173     1174       +1     
  Lines        179037   179169     +132     
  Branches       3398     3398              
============================================
+ Hits         100877   100995     +118     
- Misses        74903    74917      +14     
  Partials       3257     3257              
Flag Coverage Δ
python 81.33% <92.59%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shunping shunping self-assigned this Mar 17, 2025
@shunping shunping requested a review from damccorm March 17, 2025 13:23
@shunping shunping marked this pull request as ready for review March 17, 2025 13:23
@shunping
Copy link
Collaborator Author

r: @damccorm

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally LGTM, just had a minor comment. I'll wait on #34311 before merging anyways though (I didn't review the specifiable pieces of this PR since that is part of that PR).

custom input/output conversion and inference.
Args:
custom_detector: The `OfflineDetector` to run.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
custom_detector: The `OfflineDetector` to run.
offline_detector: The `OfflineDetector` to run.

@shunping shunping force-pushed the anomaly-detection-7 branch from 57a3381 to 94c7246 Compare March 18, 2025 19:08
Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@damccorm damccorm merged commit 3828148 into apache:master Mar 18, 2025
90 checks passed
talatuyarer pushed a commit to talatuyarer/beam that referenced this pull request Mar 20, 2025
prodriguezdefino pushed a commit to prodriguezdefino/beam-pabs that referenced this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants