-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[AnomalyDetection] Support offline detectors #34311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
60d732c to
57a3381
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #34311 +/- ##
============================================
+ Coverage 56.34% 56.36% +0.02%
Complexity 3286 3286
============================================
Files 1173 1174 +1
Lines 179037 179169 +132
Branches 3398 3398
============================================
+ Hits 100877 100995 +118
- Misses 74903 74917 +14
Partials 3257 3257
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
r: @damccorm |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
damccorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generally LGTM, just had a minor comment. I'll wait on #34311 before merging anyways though (I didn't review the specifiable pieces of this PR since that is part of that PR).
| custom input/output conversion and inference. | ||
| Args: | ||
| custom_detector: The `OfflineDetector` to run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| custom_detector: The `OfflineDetector` to run. | |
| offline_detector: The `OfflineDetector` to run. |
57a3381 to
94c7246
Compare
damccorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* Add offline detctors. * Fix typo.
* Add offline detctors. * Fix typo.
Depends on #34310