Skip to content

Conversation

@shunping
Copy link
Collaborator

@shunping shunping commented Apr 8, 2025

addresses #34587

@lostluck
Copy link
Contributor

lostluck commented Apr 8, 2025

Looks like the fix didn't fix testFlattenWithDifferentInputAndOutputCoders2 or testFlattenMultipleCoders. No worries it was worth a shot. But importantly, nothing new started failing.

Revert the change to the build.gradle and then this can be merged in.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@shunping
Copy link
Collaborator Author

shunping commented Apr 9, 2025

Looks like the fix didn't fix testFlattenWithDifferentInputAndOutputCoders2 or testFlattenMultipleCoders. No worries it was worth a shot. But importantly, nothing new started failing.

Revert the change to the build.gradle and then this can be merged in.

Done. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants