Skip to content

Prism windowed value coder #34830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lostluck merged 4 commits into from
May 4, 2025
Merged

Prism windowed value coder #34830

lostluck merged 4 commits into from
May 4, 2025

Conversation

@shunping
Copy link
Collaborator

@shunping shunping commented May 3, 2025

fixes #34829

@shunping
Copy link
Collaborator Author

shunping commented May 3, 2025

Opened a bug for samza runner since the newly added test failed to run: #34831.

@shunping shunping force-pushed the prism-windowed-value-coder branch from b935f8b to d33ac3c Compare May 4, 2025 00:35
@shunping shunping marked this pull request as ready for review May 4, 2025 01:32
@shunping shunping requested a review from lostluck May 4, 2025 01:32
@shunping shunping self-assigned this May 4, 2025
lostluck
lostluck approved these changes May 4, 2025
View reviewed changes
Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@lostluck
Copy link
Contributor

lostluck commented May 4, 2025

Looks like flink will need that filtered out too.

@shunping
Copy link
Collaborator Author

shunping commented May 4, 2025 •
edited
Loading

Looks like flink will need that filtered out too.

Flink runs fine previously. The current failure seems irrelevant to the change. Let me rerun the test one more time.

@shunping
Copy link
Collaborator Author

shunping commented May 4, 2025

Run Python Flink ValidatesRunner 3.12

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2025

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label python.
R: @lostluck for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@lostluck lostluck merged commit 4e6cbfc into apache:master May 4, 2025
102 checks passed
shunping added a commit to shunping/beam that referenced this pull request May 5, 2025
@shunping
Prism windowed value coder (apache#34830)
372f320 
* Support windowed value coder in prism.

* Add a new test case that previously failed to run in prism.

* Fix lints and trigger some validatesrunner tests.

* Disable the newly added test for samza runner.
@shunping shunping mentioned this pull request May 5, 2025
Merged
Abacn pushed a commit that referenced this pull request May 5, 2025
@shunping
Prism windowed value coder (#34830) (#34842)
998de4f 
* Support windowed value coder in prism.

* Add a new test case that previously failed to run in prism.

* Fix lints and trigger some validatesrunner tests.

* Disable the newly added test for samza runner.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lostluck lostluck lostluck approved these changes

Assignees

@shunping shunping

Labels

go Next Action: Reviewers prism python runners

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Prism failed on pipelines with reshuffle after windowing

2 participants

@shunping @lostluck