Skip to content

Conversation

@shunping
Copy link
Collaborator

@shunping shunping commented May 5, 2025

Cherrypick #34830 into release 2.65

  • Support windowed value coder in prism.

  • Add a new test case that previously failed to run in prism.

  • Fix lints and trigger some validatesrunner tests.

  • Disable the newly added test for samza runner.

* Support windowed value coder in prism.

* Add a new test case that previously failed to run in prism.

* Fix lints and trigger some validatesrunner tests.

* Disable the newly added test for samza runner.
@shunping shunping requested a review from Abacn May 5, 2025 15:29
@shunping shunping self-assigned this May 5, 2025
@shunping shunping added this to the 2.65.0 Release milestone May 5, 2025
@codecov
Copy link

codecov bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.46%. Comparing base (398b322) to head (372f320).
Report is 1 commits behind head on release-2.65.

Additional details and impacted files
@@               Coverage Diff               @@
##             release-2.65   #34842   +/-   ##
===============================================
  Coverage           56.46%   56.46%           
  Complexity           3289     3289           
===============================================
  Files                1181     1181           
  Lines              181393   181437   +44     
  Branches             3392     3392           
===============================================
+ Hits               102417   102446   +29     
- Misses              75715    75730   +15     
  Partials             3261     3261           
Flag Coverage Δ
python 81.11% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2025

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label python.
R: @lostluck for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but leaving to the Release Manager for 2.65 to merge.

@Abacn Abacn merged commit 998de4f into apache:release-2.65 May 5, 2025
105 checks passed
@shunping shunping deleted the cherrypick-34830 branch May 5, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants