Skip to content

Conversation

@shunping
Copy link
Collaborator

@shunping shunping commented May 30, 2025

Fixes #35090.

Running the same test code from #35090 (comment), we no longer see timer callback being invoked.

Furthermore, if we change the test code to set firing timestamp of a timer to be the timestamp of first element + 2 (rather than 10 in the original test), we will see the timer callback is actually called.

set timer to Timestamp(1748577640.693000)
timer callback start (timestamp=Timestamp(1748577640.693000))
timer callback elements: [1748577638.693265, 1748577639.693265, 1748577640.693265]
timer callback end
batch process start
1748577638.693265
1748577639.693265
1748577640.693265
1748577641.693265
1748577642.693265
batch process end
clear timer
set timer to Timestamp(1748577645.693000)
timer callback start (timestamp=Timestamp(1748577645.693000))
timer callback elements: [1748577643.693265, 1748577644.693265, 1748577645.693265]
timer callback end
batch process start
1748577643.693265
1748577644.693265
1748577645.693265
1748577646.693265
1748577647.693265
batch process end
clear timer
set timer to Timestamp(1748577650.693000)
timer callback start (timestamp=Timestamp(1748577650.693000))
timer callback elements: [1748577648.693265, 1748577649.693265]
timer callback end
batch process start
1748577648.693265
1748577649.693265
1748577650.693265
1748577651.693265
1748577652.693265
batch process end
clear timer
set timer to Timestamp(1748577655.693000)
timer callback start (timestamp=Timestamp(1748577655.693000))
timer callback elements: [1748577653.693265, 1748577654.693265, 1748577655.693265]
timer callback end
batch process start
1748577653.693265
1748577654.693265
1748577655.693265
1748577656.693265
1748577657.693265
batch process end
...

@shunping shunping force-pushed the prism-fix-event-timer-early-firing branch from 89e9b4f to 2cd7e70 Compare May 30, 2025 03:24
@shunping shunping self-assigned this May 30, 2025
@shunping shunping requested a review from lostluck May 30, 2025 04:02
@shunping shunping added this to the 2.66.0 Release milestone May 30, 2025
@shunping shunping changed the title Fix event timer firing earlier than the time set. Prism: Fix event-time timer firing earlier than the time set. May 30, 2025
@shunping shunping marked this pull request as ready for review May 30, 2025 04:05
@github-actions
Copy link
Contributor

Assigning reviewers:

R: @jrmccluskey for label go.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@liferoad liferoad merged commit 2e95626 into apache:master May 30, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: prism event-time timer firing early then preset time

3 participants