Skip to content

Prism: Fix event-time timer firing earlier than the time set. #35089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liferoad merged 2 commits into from
May 30, 2025
Merged

Prism: Fix event-time timer firing earlier than the time set. #35089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cd7e70
Fix event timer firing earlier than the time set.
shunping May 30, 2025
124c442
Fix timer loss issue.
shunping May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions sdks/go/pkg/beam/runners/prism/internal/engine/elementmanager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1647,6 +1647,12 @@ keysPerBundle:
timerCleared = true
continue
}
if e.timestamp > watermark {
// We don't trigger a timer when its firing timestamp is over watermark.
// Push the timer back so we won't lose it.
heap.Push(&dnt.elements, e)
break
}
holdsInBundle[e.holdTimestamp]++
// Clear the "fired" timer so subsequent matches can be ignored.
delete(dnt.timers, timerKey{family: e.family, tag: e.tag, window: e.window})
Expand Down
4 changes: 2 additions & 2 deletions sdks/go/pkg/beam/runners/prism/internal/stage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,9 +180,9 @@ func (s *stage) Execute(ctx context.Context, j *jobservices.Job, wk *worker.W, c
progTick := time.NewTicker(baseTick)
defer progTick.Stop()
var dataFinished, bundleFinished bool
// If we have no data outputs, we still need to have progress & splits
// If we have no data outputs and timers, we still need to have progress & splits
// while waiting for bundle completion.
if b.OutputCount == 0 {
if b.OutputCount+len(b.HasTimers) == 0 {
dataFinished = true
}
var resp *fnpb.ProcessBundleResponse
Expand Down
Loading