Skip to content

Conversation

@akashorabek
Copy link
Collaborator

@akashorabek akashorabek commented Jun 23, 2025

Fixes: #35285
Reverts: #35243
Successful run example: https://github.com/akashorabek/beam/actions/runs/15823702254


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@derrickaw
Copy link
Collaborator

derrickaw commented Jun 23, 2025

Hi @akashorabek - I don't think this will fix the flakiness. The failures seem not related to yaml. At least #35191 will not fix the issue.

image

@damccorm
Copy link
Contributor

It seems like there are 2 mostly unrelated reverted commits here - is there a reason you expect that both of these are issues?

@github-actions
Copy link
Contributor

Assigning reviewers:

R: @shunping for label python.
R: @Abacn for label build.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn
Copy link
Contributor

Abacn commented Jun 23, 2025

This one is in Beam 2.66 release branch. We probably need to cherry pick also

cc: @Amar3tto @damccorm

@Amar3tto
Copy link
Collaborator

I don't think we want to fix one issue and undo two other fixes, so it's better to try fix them all

@github-actions github-actions bot added build and removed build labels Jun 24, 2025
@akashorabek
Copy link
Collaborator Author

Yes, my bad, #35191 wasn't related to this issue, I deleted it from this PR. But I think we still need to revert #35243 for now as it introduced some breaking changes related to types. Discussion regarding the solution is already happening here.

@akashorabek
Copy link
Collaborator Author

Run Python PostCommit 3.10

@akashorabek
Copy link
Collaborator Author

Failing PostCommit Python check isn't related

@akashorabek akashorabek requested a review from Abacn June 25, 2025 10:46
@Abacn
Copy link
Contributor

Abacn commented Jun 25, 2025

R: @shunping what's the next step, shall we revert?

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@shunping
Copy link
Collaborator

shunping commented Jun 25, 2025

We don't revert. We will add back that workaround for xlang test only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The PostCommit Python Xlang Gcp Direct job is flaky

6 participants