-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Fix The PostCommit Python Xlang Gcp Direct job is flaky #35396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @akashorabek - I don't think this will fix the flakiness. The failures seem not related to yaml. At least #35191 will not fix the issue.
|
|
It seems like there are 2 mostly unrelated reverted commits here - is there a reason you expect that both of these are issues? |
|
Assigning reviewers: R: @shunping for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
I don't think we want to fix one issue and undo two other fixes, so it's better to try fix them all |
|
Run Python PostCommit 3.10 |
|
Failing PostCommit Python check isn't related |
|
R: @shunping what's the next step, shall we revert? |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
We don't revert. We will add back that workaround for xlang test only. |

Fixes: #35285
Reverts: #35243
Successful run example: https://github.com/akashorabek/beam/actions/runs/15823702254
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.