Fix post commit xlang jdbcio test failure #35428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
cc'ed @akashorabek @Abacn |
Contributor
|
Assigning reviewers: R: @liferoad for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Collaborator
Author
|
cc'ed @Amar3tto |
shunping
changed the title
Abacn
approved these changes
Jun 25, 2025
claudevdm
approved these changes
Jun 25, 2025
shunping
added a commit
to shunping/beam
that referenced
this pull request
Jun 27, 2025
* Temporary get the workaround back for TIMESTAMP field in jdbc. * Trigger the post commit tests.
shunping
added a commit
to shunping/beam
that referenced
this pull request
Jun 29, 2025
This reverts commit 6ac5009.
shunping
added a commit
that referenced
this pull request
Jul 17, 2025
* Another fix for jdbc timestamp logical type. - Used schema registry directly if it exists. - Fixed a bug on schema registry. - Triggered post commit tests for jdbcio. - Fixed failed tests and trigger dataflow test on xlang. - Fix schema test by adding field description in named_fields_to_schema * Apply yapf. * Revert "Fix post commit xlang jdbcio test failure (#35428)" This reverts commit 6ac5009. * Enforce MilliInstant as the logical type for Timestamp in ReadFromJDBC. * Fix a failed test on DECIMAL field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #35285
related to #35396
Temporarily add back the workaround for xlang tests because TIMESTAMP field is present in the test table.
beam/sdks/python/apache_beam/io/external/xlang_jdbcio_it_test.py
Line 189 in cb5eef5
PR #35243 covers the cases of DATE (with logical type
JdbcDateType) and TIME (with logical typeJdbcTimeType), but not TIMESTAMp (with logical typeMillisInstant).Successful run: https://github.com/apache/beam/actions/runs/15877192956/job/44767607815?pr=35428