-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Replace port_to_expose with port as testcontainers upgrade #35501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| { | ||
| "comment": "Modify this file in a trivial way to cause this test suite to run", | ||
| "modification": 11 | ||
| "modification": 12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think this test suite is necessary, it runs on dataflow.
|
Getting the following error:
|
049c425 to
240df60
Compare
|
I am trying to find out the root cause of why we need MySQLdb after testcontainers upgrade. I followed the failed test code( beam/sdks/python/apache_beam/io/external/xlang_jdbcio_it_test.py Lines 123 to 140 in 623e998
from testcontainers.mysql import MySqlContainer
container = MySqlContainer()
container.start()
print(container.get_connection_url())Connection url from version 3.7.1 Connection url from version 4.10.0 In version 3.7.1, it uses pymysql driver: In version 4.10.0, if we do not specify dialect, it will not contain a driver in the url. When we call |
|
By adding |
240df60 to
e340e50
Compare
|
Looks like the previous failed test is green now. |
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
Assigning reviewers: R: @jrmccluskey for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
damccorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
A few tests are failing (https://github.com/apache/beam/actions/runs/15985918137) due to testcontainers upgrade in (#35216).
It seems that after 4.x, testcontainers deprecated
port_to_expose(testcontainers/testcontainers-python#296).This PR attempts to forward fix this by replacing
port_to_exposewithportin our tests.