Skip to content

Conversation

@shunping
Copy link
Collaborator

@shunping shunping commented Jul 1, 2025

From the following failed test in PR #35501
https://github.com/apache/beam/runs/45163445946, looks like we need to install this dependency

@github-actions github-actions bot added the build label Jul 1, 2025
@liferoad liferoad requested a review from damccorm July 2, 2025 00:25
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025

Assigning reviewers:

R: @damccorm for label build.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@shunping
Copy link
Collaborator Author

shunping commented Jul 2, 2025

If adding the dialect (mentioned in #35501 (comment)) works, we don't need this PR.

@shunping
Copy link
Collaborator Author

shunping commented Jul 2, 2025

Given that the failed test has passed again with the fix in #35501, I think we no longer need to add this dependency. Closing this PR.

@shunping shunping closed this Jul 2, 2025
@shunping shunping deleted the add-mysqlclient branch July 14, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant