-
Notifications
You must be signed in to change notification settings - Fork 4.5k
x-lang GroupByEncryptedKey (Java to Python) #36418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #36418 +/- ##
=============================================
- Coverage 55.02% 36.21% -18.82%
Complexity 1666 1666
=============================================
Files 1058 1058
Lines 165254 165291 +37
Branches 1190 1190
=============================================
- Hits 90939 59865 -31074
- Misses 72138 103249 +31111
Partials 2177 2177
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Moved Python -> Java tests to #36457 for clarity since this now has functional changes, not just test changes. |
…mccorm/gbek-xlang-tests
|
Now seeing xvr failures with: I'd seen this locally, but had thought I'd moved past it (and did get at least one green run here). Will debug further, it seems like it could be an issue with type inference |
|
assign set of reviewers |
|
Assigning reviewers: R: @liferoad for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds cross-language tests for GroupByEncryptedKey (GBEK) from Java to Python, and includes several important fixes for cross-language pipeline option handling and coder inference. The changes in the Python SDK for merging pipeline options and explicitly setting output types are well-implemented. The new Java test for GBEK is a great addition. I've suggested a few improvements to the test code to handle resources more safely and to make the failure test case more robust.
sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/ValidateRunnerXlangTest.java
Show resolved
Hide resolved
sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/ValidateRunnerXlangTest.java
Show resolved
Hide resolved
sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/ValidateRunnerXlangTest.java
Show resolved
Hide resolved
chamikaramj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
This PR adds some x-lang tests to test that the gbek option works when calling across languages from Java to Python. Most of the fixes in this PR are related to that (+131 lines). As part of this work, though, I also noticed/fixed 2 problems:
#36457 contains the Python -> Java version of these tests.
Part of #36214
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.