Skip to content

Conversation

@damccorm
Copy link
Contributor

@damccorm damccorm commented Oct 8, 2025

Right now, Python's GBEK and Java's GBEK expect different secret formats. This standardizes on URL-safe Base64 encoding (which Python already uses), and should allow x-lang tests to pass (this is a subset of #36418 which does work)

Part of #36214


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@damccorm damccorm marked this pull request as ready for review October 8, 2025 02:17
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

Assigning reviewers:

R: @jrmccluskey for label python.
R: @chamikaramj for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the python and docstring perspective, the Java looks fine to me as well

@damccorm damccorm merged commit e410e34 into master Oct 8, 2025
142 of 144 checks passed
damccorm added a commit that referenced this pull request Oct 9, 2025
@damccorm damccorm deleted the users/damccorm/secretEncoding branch October 16, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants