[BEAM-3126] Creating flatten operation in Python SDK Harness #4408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the flatten URN to the URNs registered with the BeamTransformFactory.
|
SUCCESS --none-- |
Contributor
Author
|
R: @robertwb |
robertwb
approved these changes
Jan 16, 2018
| consumers) | ||
|
|
||
|
|
||
| @BeamTransformFactory.register_urn(urns.FLATTEN_TRANSFORM, None) |
Contributor
There was a problem hiding this comment.
Did "urns.FLATTEN_TRANSFORM" need to be updated to match Java?
Contributor
Author
There was a problem hiding this comment.
Yes, right now it differs from the one being used in Java. Since PR #4310 is being worked on to solve the discrepancies, we can wait to merge this PR until after that one is merged, or I can just make a new PR later to fix the URN. What do you think would be better? I'm leaning towards the second option.
Contributor
There was a problem hiding this comment.
OK, let's get this one in and hopefully #4310 will be merged soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue.mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.This PR is attempting to make sure the Python SDK Harness can handle receiving flattens in bundles to process (specifically pTransforms with the URN for flattens).
I'm posting this without running mvn clean verify because I couldn't get the build to work on my local machine (I think I set up the environment incorrectly) and it's a relatively small change, so I'm hoping that Jenkins will catch any issues.