Skip to content

[BEAM-3126] Creating flatten operation in Python SDK Harness #4408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertwb merged 1 commit into from
Jan 17, 2018
Merged

[BEAM-3126] Creating flatten operation in Python SDK Harness #4408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions sdks/python/apache_beam/runners/worker/bundle_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,3 +610,17 @@ def _create_combine_phase_operation(
factory.state_sampler),
transform_proto.unique_name,
consumers)


@BeamTransformFactory.register_urn(urns.FLATTEN_TRANSFORM, None)
Copy link
Contributor

@robertwb robertwb Jan 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did "urns.FLATTEN_TRANSFORM" need to be updated to match Java?

Copy link
Contributor Author

@youngoli youngoli Jan 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, right now it differs from the one being used in Java. Since PR #4310 is being worked on to solve the discrepancies, we can wait to merge this PR until after that one is merged, or I can just make a new PR later to fix the URN. What do you think would be better? I'm leaning towards the second option.

Copy link
Contributor

@robertwb robertwb Jan 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's get this one in and hopefully #4310 will be merged soon.

def create(factory, transform_id, transform_proto, unused_parameter, consumers):
return factory.augment_oldstyle_op(
operations.create_operation(
transform_proto.unique_name,
operation_specs.WorkerFlatten(
None,
[factory.get_only_output_coder(transform_proto)]),
factory.counter_factory,
factory.state_sampler),
transform_proto.unique_name,
consumers)