Skip to content

Conversation

@luke-zhu
Copy link
Contributor

DESCRIPTION HERE


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand:
    • What the pull request does
    • Why it does it
    • How it does it
    • Why this approach
  • Each commit in the pull request should have a meaningful subject line and body.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

My previous Python 3 compatibility PR converted cStringIO.StringIO to io.StringIO. This doesn't work in Python 2 because io.StringIO operates only unicode input.

@lukecwik
Copy link
Member

@charlesccychen do you mind taking a first pass and then reaching out to a contributor for review?

@aaltay
Copy link
Member

aaltay commented Feb 22, 2018

LGTM. I see some python test errors, but they are related to recently fixed issues.

@aaltay aaltay merged commit 3e5ce5c into apache:master Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants