Skip to content

Revert invalid use of io.StringIO in utils/profiler.py #4713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaltay merged 1 commit into from
Feb 22, 2018
Merged

Revert invalid use of io.StringIO in utils/profiler.py #4713

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions sdks/python/apache_beam/utils/profiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,20 @@
"""

import cProfile
import io
import logging
import os
import pstats
import sys
import tempfile
import time
import warnings
from threading import Timer

if sys.version_info[0] < 3:
import StringIO
else:
from io import StringIO


class Profile(object):
"""cProfile wrapper context for saving and logging profiler results."""
Expand Down Expand Up @@ -66,7 +71,7 @@ def __exit__(self, *args):
os.remove(filename)

if self.log_results:
s = io.StringIO()
s = StringIO()
self.stats = pstats.Stats(
self.profile, stream=s).sort_stats(Profile.SORTBY)
self.stats.print_stats()
Expand Down