[BEAM-3981] Cleanup of coders futurization. #5586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
tvalentyn
requested changes
Jun 8, 2018
Contributor
tvalentyn
left a comment
tvalentyn
left a comment
There was a problem hiding this comment.
Nice, I think this is the way to go. Glad we have a Cython expert in Beam community :)
LGTM modulo lint: W: 37, 0: Unused import sys (unused-import)
Contributor
|
Thanks! LGTM |
Specifying language_level=3 allows the dict.items() optimization. This is about a 40% speedup for 1-element dicts as well as cleaner code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying language_level=3 allows the dict.items() optimization.
This is about a 40% speedup for 1-element dicts as well as cleaner code.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.