Skip to content

[BEAM-3981] Cleanup of coders futurization. #5586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertwb merged 1 commit into from
Jun 8, 2018
Merged

[BEAM-3981] Cleanup of coders futurization. #5586

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions sdks/python/apache_beam/coders/coder_impl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
# limitations under the License.
#

# cython: language_level=3

"""Coder implementations.

The actual encode/decode implementations are split off from coders to
Expand All @@ -32,7 +34,6 @@
from __future__ import absolute_import
from __future__ import division

import sys
from builtins import chr
from builtins import object

Expand Down Expand Up @@ -310,13 +311,7 @@ def encode_to_stream(self, value, stream, nested):
dict_value = value # for typing
stream.write_byte(DICT_TYPE)
stream.write_var_int64(len(dict_value))
# Use iteritems() on Python 2 instead of future.builtins.iteritems to
# avoid performance regression in Cython compiled code.
if sys.version_info[0] == 2:
items = dict_value.iteritems() # pylint: disable=dict-iter-method
else:
items = dict_value.items()
for k, v in items:
for k, v in dict_value.items():
self.encode_to_stream(k, stream, True)
self.encode_to_stream(v, stream, True)
elif t is bool:
Expand Down