Improve the reliability of mvn verify
#57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows easy setting of the compiler source and target version to 1.8 without any fragile plugin configuration. It also allows the import into Eclipse to easily set separate compliance levels, as this is done per-Eclipse-project.
This allows easy setting of the compiler source and target version to
1.8 without any fragile plugin configuration. It also allows the
import into Eclipse to easily set separate compliance levels, as this
is done per-Eclipse-project.
This parallels the approach taken with tests to support java 8.
Also fixed some Checkstyle and unused variable warnings in the examples.
These were previously hidden since the code wasn't in a directory like
`src/{main,test}/java`. The warnings got fixed while I had the files
open.
The class files are already available in the tests. This required moving the Avro plugin to the regular generate-sources phase. Running it during generate-test-sources was removing the META-INF from the target/classes directory, which caused test failures due to removing the generated auto-services definitions.
Contributor
Author
|
R: @kennknowles |
| * | ||
| * <p> Run {@link injector.Injector} to generate pubsub data for this pipeline. The Injector | ||
| * documentation provides more detail. | ||
| * <p> Run {@literal com.google.cloud.dataflow.examples.complete.game.injector.Injector} to generate |
Member
There was a problem hiding this comment.
@code. I'll fix up when merging.
Member
|
LGTM. I'll wait for CI and then merge. |
Member
|
We need to fix this up a little -- this is polluting the top-level directory structure. I think |
axelmagn
pushed a commit
to axelmagn/beam
that referenced
this pull request
Apr 9, 2018
Fix window assignments in the Flink portable runner
hengfengli
referenced
this pull request
in hengfengli/beam
Mar 21, 2022
alnzng
pushed a commit
to alnzng/beam
that referenced
this pull request
Dec 25, 2022
* Samza runner support for non unique stateId across multiple ParDos (apache#24276) * Update version
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
* feat: integrate limit_to_last changes from apache#57 to async * fix: whitespace in docs * fix: whitespace in docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits make the following changes to improve reliability of
mvn verifyand interaction with IDEs: