Skip to content

Improve the reliability of mvn verify #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asfgit merged 4 commits into from
Mar 17, 2016
Merged

Improve the reliability of mvn verify #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f06e2a9
Add casts to fix mvn verify errors
Mar 16, 2016
e8b7100
Move Java 8 tests to their own module
kennknowles Mar 1, 2016
e5c7cf8
Move Java 8 examples to their own module
Mar 16, 2016
e607237
Remove the JARs from the test additionalClasspath
Mar 17, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
127 changes: 0 additions & 127 deletions examples/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,133 +45,6 @@
<testParallelValue>both</testParallelValue>
</properties>
</profile>

<profile>
<id>java8</id>
<activation>
<jdk>[1.8,)</jdk>
</activation>

<build>
<plugins>
<!-- Tells Maven about the Java 8 main and test source root. -->
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>build-helper-maven-plugin</artifactId>
<executions>
<execution>
<id>add-java8-main-source</id>
<phase>initialize</phase>
<goals>
<goal>add-source</goal>
</goals>
<configuration>
<sources>
<source>${project.basedir}/src/main/java8</source>
</sources>
</configuration>
</execution>

<execution>
<id>add-java8-test-source</id>
<phase>initialize</phase>
<goals>
<goal>add-test-source</goal>
</goals>
<configuration>
<sources>
<source>${project.basedir}/src/test/java8</source>
</sources>
</configuration>
</execution>
</executions>
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<executions>

<!-- Set `-source 1.7 -target 1.7` for Java 7 tests -->
<execution>
<id>default-testCompile</id>
<phase>test-compile</phase>
<goals>
<goal>testCompile</goal>
</goals>
<configuration>
<testSource>1.7</testSource>
<testTarget>1.7</testTarget>
<testExcludes>
<!-- This pattern is brittle; we would prefer to filter on the directory
but that seems to be unavailable to us. -->
<exclude>**/*Java8Test.java</exclude>
<exclude>**/game/**/*.java</exclude>
</testExcludes>
</configuration>
</execution>

<!-- Set `-source 1.8 -target 1.8` for Java 8 tests -->
<execution>
<id>java8-test-compile</id>
<phase>test-compile</phase>
<goals>
<goal>testCompile</goal>
</goals>
<configuration>
<testSource>1.8</testSource>
<testTarget>1.8</testTarget>
<includes>
<!-- This pattern is brittle; we would prefer to filter on the directory
but that seems to be unavailable to us. -->
<include>**/*Java8Test.java</include>
<include>**/game/**/*.java</include>
</includes>
</configuration>
</execution>

<!-- Set `-source 1.7 -target 1.7` for Java 7 examples -->
<execution>
<id>default-compile</id>
<phase>compile</phase>
<goals>
<goal>compile</goal>
</goals>
<configuration>
<source>1.7</source>
<target>1.7</target>
<excludes>
<!-- This pattern is brittle; we would prefer to filter on the directory
but that seems to be unavailable to us. -->
<exclude>**/*Java8*.java</exclude>
<exclude>**/game/**/*.java</exclude>
</excludes>
</configuration>
</execution>

<!-- Set `-source 1.8 -target 1.8` for Java 8 examples -->
<execution>
<id>java8-compile</id>
<phase>compile</phase>
<goals>
<goal>compile</goal>
</goals>
<configuration>
<source>1.8</source>
<target>1.8</target>
<includes>
<!-- This pattern is brittle; we would prefer to filter on the directory
but that seems to be unavailable to us. -->
<include>**/*Java8*.java</include>
<include>**/game/**/*.java</include>
</includes>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
</profile>
</profiles>

<build>
Expand Down
Loading