[BEAM-119] Integrate DisplayData into DataflowPipelineRunner #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
|
||
| private void addDisplayData(String name, DisplayData displayData) { | ||
| List<Map<String, Object>> serializedItems = Lists.newArrayList(); | ||
| ObjectMapper mapper = MAPPER.setSerializationInclusion(JsonInclude.Include.NON_NULL); |
Contributor
There was a problem hiding this comment.
Does this mutate MAPPER?
If yes, isn't that a problem?
If no, would it make sense to have a separate static "NON_NULL_MAPPER" so we don't need to create a new mapper for every step? Any performance risk there?
Contributor
|
LGTM. @kennknowles in your court |
Member
|
LGTM |
swegner
force-pushed
the
displaydata-runner
branch
from
f86cabe to
46946ea
Compare
davorbonaci
added a commit
to GoogleCloudPlatform/DataflowJavaSDK
that referenced
this pull request
Apr 4, 2016
hengfengli
referenced
this pull request
in hengfengli/beam
Mar 21, 2022
ryucc
added a commit
to ryucc/beam
that referenced
this pull request
Jan 27, 2023
Move Samza portable metric warning logs to debug level
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translate registered display data into the job steps used by DataflowPipelineRunner.