Replace unambiguous of throw Throwables.propagate with definition
#70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
R: @lukecwik It also looks like there might be some poor handling of an |
In the SDK the path taken by Throwables.propagate is always statically known, and the inlined logic is more explicit and readable: - If an exception e is already a checked exception, Throwables.propagate(e) is the same as `throw new RuntimeException(e)`. - If an exception e is already a RuntimeException or Error, Throwables.propagate(e) is the same as `throw e`.
kennknowles
force-pushed
the
throwables-propagate
branch
from
5c13f33 to
8a8a3d4
Compare
| if (currentLatch > 0) { | ||
| countDownLatches[currentLatch - 1].countDown(); | ||
| } | ||
| } catch (InterruptedException e) { |
Member
There was a problem hiding this comment.
Please add Thread.currentThread().interrupt() before the throws
Member
Author
There was a problem hiding this comment.
Done. (just below the diff)
Contributor
|
@kennknowles @lukecwik ping? |
Member
Author
|
pong |
Member
|
LGTM |
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the SDK the path taken by
Throwables.propagateis always statically known, and the inlined logic is more explicit and readable:Throwables.propagate(e)is the same as
throw new RuntimeException(e).RuntimeExceptionorError,Throwables.propagate(e)is the same asthrow e.