Set sdk_location for Python 3 integration tests #7793
Conversation
|
Run Python PostCommit |
| def testOpts = [ | ||
| "--tests=${tests.join(',')}", | ||
| "--nocapture", // Print stdout instantly | ||
| "--processes=1", // Number of tests running in parallel |
There was a problem hiding this comment.
Why do we have to set this now, and didn't have to in the past?
There was a problem hiding this comment.
It's not required for the fix. The main reason to have this and timeout flag is to fail fast if pipeline hangs. Otherwise the build will hit Gradle timeout which is over 100mins.
There was a problem hiding this comment.
Ok I undesrtand timeout part, but not sure why we need to add --processes - is this a tox flag? What would happen in --processes=2? Do we ever want to do that?
|
Looking at pypa/setuptools#1222 it seems that setuptools + distutils don't support concurrent operations on the same |
|
Separate folder approach may provide better isolation. |
|
#7817 put python 3 tests in separate Jenkins job. |
2 participants
Otherwise
:beam-sdks-python-precommit-dataflow-py3:precommitITwill use default distribution file that's generated by Python 2 tests in same Jenkins build.This change fix Python PostCommit failure (example link), and also correct how we build source distribution through Gradle:
cd {pySdkRoot} && python setup.py sdistinstead ofpython {pySdkRoot}/setup.py sdistFollow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)