Fix PostCommit Python 3 build failure #7817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markflyhigh
force-pushed
the
py3-fix-it
branch
from
d2902ae to
1d84d93
Compare
Contributor
Author
|
Run Seed Job |
Contributor
Author
|
Run Python3 PostCommit |
Contributor
Author
|
Run Python PostCommit |
Contributor
Author
charlesccychen
approved these changes
Feb 12, 2019
Contributor
charlesccychen
left a comment
charlesccychen
left a comment
There was a problem hiding this comment.
Thanks! This LGTM.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put Python 3 integration tests into separate Python PostCommit Jenkins job due to
a race condition in #7793 (comment).
This PR will fix current Python PostCommit failure.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)