-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[BEAM-77] IOs module creation, and reorg of IOs #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| @@ -0,0 +1,99 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <!-- | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
call it io, not ios.
bigtable goes in the Google Cloud Platform module -- io.gcp.bigtable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I tried to "mimic" runners, sdks where we have a 's'. However, no problem to use io instead.
For io.gcp.bigtable, I guess you talk about the package to use, right ?
|
I close this PR to open one PR per IO. |
Leaving existing (old) conftest JSON files in place for now. in order to get the conftest runner working using existing semantics, before updating the JSON files and making required changes (to use 'update_transforms', for instance) in a future PR. Closes apache#95. Co-authored-by: Christopher Wilcox <crwilcox@google.com>
[BEAM-77] Create a new IOs module, and start to move the different IOs there
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
mvn clean verify. (Even better, enableTravis-CI for on your fork and ensure the whole test matrix passes).
number, if there is one.
Individual Contributor License Agreement.