[BEAM-50] BigQueryIO: fix autocompleting project and test it #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Require a schema if creating a table. | ||
| checkArgument( | ||
| createDisposition != CreateDisposition.CREATE_IF_NEEDED || jsonSchema != null, | ||
| "CreateDisposition is %s, however no schema was provided.", |
Contributor
There was a problem hiding this comment.
no need to use %s, it only fails if CreateDisposition is CREATE_IF_NEEDED
Contributor
|
LGTM |
dhalperi
force-pushed
the
bigquery-write-project-id
branch
from
8419e88 to
f61d4e2
Compare
dhalperi
force-pushed
the
bigquery-write-project-id
branch
from
f61d4e2 to
e3c876c
Compare
swegner
pushed a commit
to swegner/beam
that referenced
this pull request
Apr 22, 2016
Override BigQueryIO.Write with native sink for Dataflow runner
peihe
pushed a commit
to peihe/DataflowJavaSDK
that referenced
this pull request
Apr 26, 2016
This is a backport of apache/beam#205
iemejia
added a commit
to iemejia/beam
that referenced
this pull request
Jan 12, 2018
mareksimunek
pushed a commit
to mareksimunek/beam
that referenced
this pull request
May 9, 2018
[euphoria-hbase] apache#181 add bulk loading to hbase sink
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
Leaving existing (old) conftest JSON files in place for now. in order to get the conftest runner working using existing semantics, before updating the JSON files and making required changes (to use 'update_transforms', for instance) in a future PR. Closes apache#95. Co-authored-by: Christopher Wilcox <crwilcox@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @peihe