[BEAM-188] Write: apply GlobalWindows first #181
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And do not supply a timestamp when outputting. Note that this is safe because the functions in the Writer cannot access the window or timestamp. When we add per-Window or similar functions to the sinks, we will likely do so at a higher level.
Contributor
Author
|
R: @bjchambers @dpmills @kennknowles Roughly any 2 will do. |
Contributor
|
LGTM |
| .apply(window) | ||
| .apply(ParDo.of(new AddArbitraryKey<T>())) | ||
| .apply(GroupByKey.<Integer, T>create()) | ||
| .apply(ParDo.of(new RemoveArbitraryKey<T>())); |
Contributor
There was a problem hiding this comment.
Up to you, but you can use Values.create() and Flatten.flattenIterables() instead of RemoveArbitraryKey
Contributor
|
LGTM |
swegner
pushed a commit
to swegner/beam
that referenced
this pull request
Apr 22, 2016
iemejia
pushed a commit
to iemejia/beam
that referenced
this pull request
Jan 12, 2018
mareksimunek
pushed a commit
to mareksimunek/beam
that referenced
this pull request
May 9, 2018
mareksimunek
pushed a commit
to mareksimunek/beam
that referenced
this pull request
May 9, 2018
mareksimunek
pushed a commit
to mareksimunek/beam
that referenced
this pull request
May 9, 2018
mareksimunek
pushed a commit
to mareksimunek/beam
that referenced
this pull request
May 9, 2018
[euphoria-hbase] apache#181 add bulk loading to hbase sink
dmvk
pushed a commit
to dmvk/beam
that referenced
this pull request
May 15, 2018
dmvk
added a commit
to dmvk/beam
that referenced
this pull request
May 15, 2018
dmvk
pushed a commit
to dmvk/beam
that referenced
this pull request
May 15, 2018
mareksimunek
pushed a commit
to seznam/beam
that referenced
this pull request
Jul 9, 2018
mareksimunek
pushed a commit
to seznam/beam
that referenced
this pull request
Jul 9, 2018
mareksimunek
pushed a commit
to seznam/beam
that referenced
this pull request
Jul 9, 2018
dmvk
pushed a commit
to seznam/beam
that referenced
this pull request
Aug 17, 2018
dmvk
added a commit
to seznam/beam
that referenced
this pull request
Aug 17, 2018
dmvk
pushed a commit
to seznam/beam
that referenced
this pull request
Aug 17, 2018
dmvk
pushed a commit
to seznam/beam
that referenced
this pull request
Oct 5, 2018
dmvk
added a commit
to seznam/beam
that referenced
this pull request
Oct 5, 2018
dmvk
pushed a commit
to seznam/beam
that referenced
this pull request
Oct 5, 2018
damccorm
pushed a commit
that referenced
this pull request
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And do not supply a timestamp when outputting.
Note that this is safe because the functions in the Writer cannot access the window
or timestamp. When we add per-Window or similar functions to the sinks, we will
likely do so at a higher level.
Also testing and improving the existing tests. Note that the session test did fail without the accompanying changes to Write.