-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[BEAM-8204][BEAM-8205] Exclude AvroSchemaTest for Apex and Flink runner for now #9541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Run Flink ValidatesRunner |
|
Run Apex ValidatesRunner |
|
Run Flink ValidatesRunner |
|
Run Apex ValidatesRunner |
|
How are they breaking those runners? This test should be working fine on
those runners AFAIK.
…On Tue, Sep 10, 2019 at 5:53 PM Yueyang Qiu ***@***.***> wrote:
Run Apex ValidatesRunner
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9541?email_source=notifications&email_token=AFAYJVLD2EEFCDERKGEZLJTQJA6PZA5CNFSM4IVN4VMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6M5DLY#issuecomment-530174383>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFAYJVJ6IMOT3OEHV6QOIRDQJA6PZANCNFSM4IVN4VMA>
.
|
|
I'm not really up to speed on what's going on here, but both Apex and Flink seem upset about coders of two different types, if that helps. From the Flink run: and from the Apex run: |
markflyhigh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Robin to keep ValidatesRunner test green. This PR LGTM.
|
+1 LGTM. I think @reuvenlax is right that #9446's addition of SchemaCoder.equals may fix this, but it's not fully baked yet. I think we should just skip until we can get the equality check right and un-skip these. |
|
Technically I think Flink should not be relying on comparing coders. Beam
has never required Coder authors to implement a Java equals method, and
other runners don't do such Coder comparisons on flatten. However for now
we can disable the test on Flink.
…On Wed, Sep 11, 2019 at 1:07 PM Brian Hulette ***@***.***> wrote:
+1 LGTM. I think @reuvenlax <https://github.com/reuvenlax> is right that
#9446 <#9446>'s addition of
SchemaCoder.equals may fix this, but it's not fully baked yet. I think we
should just skip until we can get the equality check right and un-skip
these.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9541?email_source=notifications&email_token=AFAYJVJDFAZZIPKEDUFJP5DQJFFX7A5CNFSM4IVN4VMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6PXNZA#issuecomment-530544356>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFAYJVORR3UE3KAPFPZHBWDQJFFX7ANCNFSM4IVN4VMA>
.
|
|
Got enough lgtm. I'll merge this. |
Exclude the test because they are currently breaking post-commit tests.
The test was added in #9454
r: @TheNeuralBit @reuvenlax
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.