Skip to content

Conversation

@robinyqiu
Copy link
Contributor

@robinyqiu robinyqiu commented Sep 11, 2019

Exclude the test because they are currently breaking post-commit tests.

The test was added in #9454

r: @TheNeuralBit @reuvenlax

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@robinyqiu
Copy link
Contributor Author

Run Flink ValidatesRunner

@robinyqiu
Copy link
Contributor Author

Run Apex ValidatesRunner

@robinyqiu
Copy link
Contributor Author

Run Flink ValidatesRunner

@robinyqiu
Copy link
Contributor Author

Run Apex ValidatesRunner

@reuvenlax
Copy link
Contributor

reuvenlax commented Sep 11, 2019 via email

@TheNeuralBit
Copy link
Member

I'm not really up to speed on what's going on here, but both Apex and Flink seem upset about coders of two different types, if that helps. From the Flink run:

org.apache.beam.sdk.Pipeline$PipelineExecutionException: org.apache.flink.api.common.InvalidProgramException: Cannot union inputs of different types. 

and from the Apex run:

org.apache.apex.api.Launcher$LauncherException: java.lang.UnsupportedOperationException: ParMultiDo(Anonymous): Multiple side inputs with different coders.

@robinyqiu
Copy link
Contributor Author

Yes, and full error messages are here and here.

Copy link
Contributor

@markflyhigh markflyhigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Robin to keep ValidatesRunner test green. This PR LGTM.

@TheNeuralBit
Copy link
Member

+1 LGTM. I think @reuvenlax is right that #9446's addition of SchemaCoder.equals may fix this, but it's not fully baked yet. I think we should just skip until we can get the equality check right and un-skip these.

@reuvenlax
Copy link
Contributor

reuvenlax commented Sep 11, 2019 via email

@markflyhigh
Copy link
Contributor

Got enough lgtm. I'll merge this.

@markflyhigh markflyhigh merged commit 8f91984 into apache:master Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants