Revert "[BEAM-8111] Add ValidatesRunner test to AvroSchemaTest" #9550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t to AvroSchemaTest" This reverts commit 58a12b6.
Contributor
|
FYI this appears to be Flink ValidatesRunner, not Dataflow?
…On Wed, Sep 11, 2019 at 11:30 AM Mark Liu ***@***.***> wrote:
@markflyhigh <https://github.com/markflyhigh> requested your review on:
#9550 <#9550> Revert "[BEAM-8111] Add
ValidatesRunner test to AvroSchemaTest".
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#9550?email_source=notifications&email_token=AFAYJVNDZVD773KSV7FB743QJE2OFA5CNFSM4IVXMSBKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOTSINQNY#event-2626738231>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFAYJVPTEZ3RFDFQEQSVIILQJE2OFANCNFSM4IVXMSBA>
.
|
Contributor
|
Also it appears that Flink relies on all the Coders being exactly the same,
which is far more restrictive than other runners. Is there another way for
Flink to do this - maybe comparing the TypeDescriptor instead of the Coder?
…On Wed, Sep 11, 2019 at 11:54 AM Reuven Lax ***@***.***> wrote:
FYI this appears to be Flink ValidatesRunner, not Dataflow?
On Wed, Sep 11, 2019 at 11:30 AM Mark Liu ***@***.***>
wrote:
> @markflyhigh <https://github.com/markflyhigh> requested your review on:
> #9550 <#9550> Revert "[BEAM-8111] Add
> ValidatesRunner test to AvroSchemaTest".
>
> —
> You are receiving this because your review was requested.
> Reply to this email directly, view it on GitHub
> <#9550?email_source=notifications&email_token=AFAYJVNDZVD773KSV7FB743QJE2OFA5CNFSM4IVXMSBKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOTSINQNY#event-2626738231>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AFAYJVPTEZ3RFDFQEQSVIILQJE2OFANCNFSM4IVXMSBA>
> .
>
|
Contributor
|
Also I suspect that #9446 will fix this.
…On Wed, Sep 11, 2019 at 12:05 PM Reuven Lax ***@***.***> wrote:
Also it appears that Flink relies on all the Coders being exactly the
same, which is far more restrictive than other runners. Is there another
way for Flink to do this - maybe comparing the TypeDescriptor instead of
the Coder?
On Wed, Sep 11, 2019 at 11:54 AM Reuven Lax ***@***.***> wrote:
> FYI this appears to be Flink ValidatesRunner, not Dataflow?
>
> On Wed, Sep 11, 2019 at 11:30 AM Mark Liu ***@***.***>
> wrote:
>
>> @markflyhigh <https://github.com/markflyhigh> requested your review on:
>> #9550 <#9550> Revert "[BEAM-8111]
>> Add ValidatesRunner test to AvroSchemaTest".
>>
>> —
>> You are receiving this because your review was requested.
>> Reply to this email directly, view it on GitHub
>> <#9550?email_source=notifications&email_token=AFAYJVNDZVD773KSV7FB743QJE2OFA5CNFSM4IVXMSBKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOTSINQNY#event-2626738231>,
>> or mute the thread
>> <https://github.com/notifications/unsubscribe-auth/AFAYJVPTEZ3RFDFQEQSVIILQJE2OFANCNFSM4IVXMSBA>
>> .
>>
>
|
Contributor
Author
Contributor
|
So should this be closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #9454 due to AvroSchemaTest.testAvroPipelineGroupBy consistently failed in Flink ValidatesRunner test suite (link).
This is the first failure instance. You can go to console output or Gradle scan for error details.
+R: @reuvenlax @kennknowles @lukecwik