Skip to content

Conversation

@udim
Copy link
Member

@udim udim commented Sep 12, 2019

In Python 3 with funcsigs installed, prefer inspect.{signature,Paramter}
over funcsigs equivalents.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

In Python 3 with funcsigs installed, prefer inspect.{signature,Paramter}
over funcsigs equivalents.
@udim
Copy link
Member Author

udim commented Sep 12, 2019

R: @robinyqiu

@udim udim merged commit 43ae56a into apache:master Sep 12, 2019
@robertwb
Copy link
Contributor

Should this be cherry-picked into the release?

@udim
Copy link
Member Author

udim commented Sep 19, 2019

Probably, yes

@udim
Copy link
Member Author

udim commented Sep 19, 2019

I'll make one

markflyhigh added a commit that referenced this pull request Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants