Skip to content

Conversation

@aaltay
Copy link
Member

@aaltay aaltay commented Sep 13, 2019

Reverts #9098

Py 3.7 tests are failing with a syntax error.

@aaltay
Copy link
Member Author

aaltay commented Sep 13, 2019

R: @chadrik @robertwb @udim

@aaltay aaltay requested review from robertwb and udim September 13, 2019 16:12
@chadrik
Copy link
Contributor

chadrik commented Sep 13, 2019

I introduced some tests of a feature that makes use of PEP526 syntax changes introduced in python 3.6. I got everything passing for the pre-commit tests but did not anticipate the post-commit problems. I'll get those fixed up ASAP.

@chadrik
Copy link
Contributor

chadrik commented Sep 13, 2019

Note that the other solution to this is dropping support for python 3.5, but that's a bigger discussion.

@aaltay
Copy link
Member Author

aaltay commented Sep 13, 2019

I was wrong in my JIRA issue. Py2 post commit is failing on py3.7 test. I thought py2 post commit was meant to skip these files.

@aaltay
Copy link
Member Author

aaltay commented Sep 13, 2019

Run Portable_Python PreCommit

@aaltay
Copy link
Member Author

aaltay commented Sep 13, 2019

Run Python 2 PostCommit

@aaltay
Copy link
Member Author

aaltay commented Sep 13, 2019

Closing this. #9570 - addressed the test issues.

@aaltay aaltay closed this Sep 13, 2019
@pabloem pabloem deleted the revert-9098-py_external_api branch September 25, 2019 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants