Skip to content

Conversation

@chadrik
Copy link
Contributor

@chadrik chadrik commented Sep 13, 2019

Fixes #9098 and removes the need for #9565.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@chadrik
Copy link
Contributor Author

chadrik commented Sep 13, 2019

R: @aaltay
R: @robertwb

Here's a quick fix if you want to use this instead of reverting and resubmitting #9098.

It would be good if we could preemptively run post-commit test, since running the integration tests on my laptop seems like a bit of a non-starter.

@chadrik
Copy link
Contributor Author

chadrik commented Sep 13, 2019

Run Python PostCommit

@aaltay
Copy link
Member

aaltay commented Sep 13, 2019

Run Python 2 PostCommit

@chadrik
Copy link
Contributor Author

chadrik commented Sep 13, 2019

Run Python 3.5 PostCommit

@chadrik
Copy link
Contributor Author

chadrik commented Sep 13, 2019

Run Python 3.6 PostCommit

Copy link
Contributor

@robertwb robertwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring this out; let's see if it fixes all the tests.

@chadrik
Copy link
Contributor Author

chadrik commented Sep 13, 2019

I'm happy to clean up my own mess. Sorry about the downtime, still learning my way around the build system.

@chadrik
Copy link
Contributor Author

chadrik commented Sep 13, 2019

@robertwb speaking of builds, you may be interested to weigh in on this ticket: https://jira.apache.org/jira/projects/BEAM/issues/BEAM-8213

@chadrik
Copy link
Contributor Author

chadrik commented Sep 13, 2019

Looks like this is ready to go

@markflyhigh
Copy link
Contributor

Thank you @chadrik for this quick fix! I can merge since you got enough approvals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants