Skip to content

Conversation

@StevenLuMT
Copy link
Member

@StevenLuMT StevenLuMT commented Jan 14, 2022

Descriptions of the changes in this PR:

Motivation

  1. pr: BP-46: Data integrity check for running without journal #2936 miss rxjava maven dependency
  2. the default workflow check just build with gradle,miss the maven build,so the problem of maven compilation is easy to be ignored, do we need to open maven compilation in default workflow?

image

Changes

rxjava: add maven dependency

PS

Bookkeeper committer I can't be missing......Ha Ha Ha

@StevenLuMT
Copy link
Member Author

@eolivelli @pkumar-singh @zymap @Vanlightly
If you have time, please help me review it, thank you

@zymap
Copy link
Member

zymap commented Jan 17, 2022

I think we are aborting the Maven support and migrating to the Gradle. https://bookkeeper.apache.org/bps/BP-43-gradle-migration/. Could you please check the Gradle build is ok?

@StevenLuMT
Copy link
Member Author

StevenLuMT commented Jan 17, 2022

I think we are aborting the Maven support and migrating to the Gradle. https://bookkeeper.apache.org/bps/BP-43-gradle-migration/. Could you please check the Gradle build is ok?

yes,the Gradle build is ok, I have checked @zymap

@StevenLuMT
Copy link
Member Author

@eolivelli @pkumar-singh @Vanlightly
If you have time, please help me review it, thank you

@pkumar-singh
Copy link
Member

@StevenLuMT Yeah. Hopefully in a week or so we will be able to shutdown maven for good.

@dlg99
Copy link
Contributor

dlg99 commented Feb 9, 2022

No longer needed after #3009 and #3018

@dlg99 dlg99 closed this Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants