[build] remove Maven POM files #3009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
rerun failure checks |
Contributor
Author
|
@pkumar-singh @hsaputra PTAL |
dlg99
approved these changes
Jan 26, 2022
pkumar-singh
approved these changes
Jan 26, 2022
Member
|
LGTM. |
Member
|
We may also have to update docs on how to build run tests etc. Run just one test. Run all tests in the class. Build only without building tests. Build all but not run tests, etc. |
StevenLuMT
pushed a commit
to StevenLuMT/bookkeeper
that referenced
this pull request
Feb 16, 2022
* Initial commit for dropping maven * fix gh action * fix typo
dlg99
added a commit
to dlg99/bookkeeper
that referenced
this pull request
Mar 22, 2022
This reverts commit e089b51.
eolivelli
pushed a commit
that referenced
this pull request
Mar 24, 2022
* Revert "[build] remove Maven POM files (#3009)" This reverts commit e089b51. * rxjava: add maven dependency (cherry picked from commit ac73541) * Bring guava to the same version as gradle * ignore deprecation warnings in tests * mockito-inline, as in gradle + suppress warnings * suppressed warning * Exclude site3/ from RAT check * CI to use (mostly) maven * OWASP check with maven * Up'd versions to match gradle, corrected license files: looks like gradle build didn't force versions consistently * Removed current-version-image to match #3027 * Shading patetrn to match gradle * Fixed/suppressed CVEs * Attempt to fix failing tests in CompactionByEntriesWithMetadataCacheTest Co-authored-by: lushiji <lushiji@didiglobal.com>
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
* Initial commit for dropping maven * fix gh action * fix typo
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
* Revert "[build] remove Maven POM files (apache#3009)" This reverts commit e089b51. * rxjava: add maven dependency (cherry picked from commit ac73541) * Bring guava to the same version as gradle * ignore deprecation warnings in tests * mockito-inline, as in gradle + suppress warnings * suppressed warning * Exclude site3/ from RAT check * CI to use (mostly) maven * OWASP check with maven * Up'd versions to match gradle, corrected license files: looks like gradle build didn't force versions consistently * Removed current-version-image to match apache#3027 * Shading patetrn to match gradle * Fixed/suppressed CVEs * Attempt to fix failing tests in CompactionByEntriesWithMetadataCacheTest Co-authored-by: lushiji <lushiji@didiglobal.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The POM are not needed anymore
Changes
binstarts well using the development versionNot yet: