[ci] Move CI to JDK11 #3027
Merged
[ci] Move CI to JDK11 #3027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoloboschi
force-pushed
the
ci-jdk11
branch
from
27b9a3a to
72f70b8
Compare
Contributor
Author
|
rerun failure checks |
Contributor
Author
|
rerun failure checks |
Contributor
Author
|
rerun failure checks |
1 similar comment
Contributor
Author
|
rerun failure checks |
Contributor
Author
|
rerun failure checks |
1 similar comment
Contributor
Author
|
rerun failure checks |
Contributor
Author
|
@eolivelli @dlg99 @merlimat PTAL |
Member
|
Can we use a matrix to run both the jdk1.8 and jdk11? |
Contributor
Author
|
The matrix adds a significant overhead for every pull request since the tests execution is doubled. Also, from a mid-term perspective, when we will upgrade to JDK 17 (or next lts) it's not a good idea to duplicate the CI jobs another time. |
Contributor
Author
|
@dlg99 I think we could merge this before the release branch creation |
eolivelli
approved these changes
Mar 2, 2022
dlg99
added a commit
to dlg99/bookkeeper
that referenced
this pull request
Mar 22, 2022
eolivelli
pushed a commit
that referenced
this pull request
Mar 24, 2022
* Revert "[build] remove Maven POM files (#3009)" This reverts commit e089b51. * rxjava: add maven dependency (cherry picked from commit ac73541) * Bring guava to the same version as gradle * ignore deprecation warnings in tests * mockito-inline, as in gradle + suppress warnings * suppressed warning * Exclude site3/ from RAT check * CI to use (mostly) maven * OWASP check with maven * Up'd versions to match gradle, corrected license files: looks like gradle build didn't force versions consistently * Removed current-version-image to match #3027 * Shading patetrn to match gradle * Fixed/suppressed CVEs * Attempt to fix failing tests in CompactionByEntriesWithMetadataCacheTest Co-authored-by: lushiji <lushiji@didiglobal.com>
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
* Revert "[build] remove Maven POM files (apache#3009)" This reverts commit e089b51. * rxjava: add maven dependency (cherry picked from commit ac73541) * Bring guava to the same version as gradle * ignore deprecation warnings in tests * mockito-inline, as in gradle + suppress warnings * suppressed warning * Exclude site3/ from RAT check * CI to use (mostly) maven * OWASP check with maven * Up'd versions to match gradle, corrected license files: looks like gradle build didn't force versions consistently * Removed current-version-image to match apache#3027 * Shading patetrn to match gradle * Fixed/suppressed CVEs * Attempt to fix failing tests in CompactionByEntriesWithMetadataCacheTest Co-authored-by: lushiji <lushiji@didiglobal.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master issue: #3025
Motivation
BookKeeper has been running with JDK11 for a long time. The official docker image is using JDK11 so it's much better to verify the codebase using JDK11
Changes