Bringing back maven build #3130
Conversation
nicoloboschi
left a comment
nicoloboschi
left a comment
There was a problem hiding this comment.
Are you able to restore github actions? In this way we are sure the build is stable
|
Apache RAT fails due to "site3" directory, please add the exclusion: |
|
I built the package locally and run "localbookie" and a small bookkeeper cluster (tested with BKVM). |
|
Unit tests seem to pass locally (I didn't run integration tests) |
|
@nicoloboschi @eolivelli I could not just revert the changes for the GH actions because there commit after that. I did the changes manually/picked them from branch 4.14 mostly. I left javadoc generation with gradle. Backwards compat tests also left running with gradle, plus added one action that simply builds everything with gradle but does not run tests. |
|
There are problems with the license check |
|
Problems with the docker image for tests |
…adle build didn't force versions consistently
|
Very good! |
|
I fixed @eolivelli @nicoloboschi Please take another look. |
nicoloboschi
left a comment
nicoloboschi
left a comment
There was a problem hiding this comment.
I did some checks locally:
- build with mvn (no tests)
- started a bookie and run simple test shell command
- checked dependencies versions matching between maven and gradle
great work @dlg99 !
zymap
left a comment
zymap
left a comment
There was a problem hiding this comment.
+1
Build with this branch
Run the zookeeper server + 1 bookie
Run the simpletest command successfully
* Revert "[build] remove Maven POM files (apache#3009)" This reverts commit e089b51. * rxjava: add maven dependency (cherry picked from commit ac73541) * Bring guava to the same version as gradle * ignore deprecation warnings in tests * mockito-inline, as in gradle + suppress warnings * suppressed warning * Exclude site3/ from RAT check * CI to use (mostly) maven * OWASP check with maven * Up'd versions to match gradle, corrected license files: looks like gradle build didn't force versions consistently * Removed current-version-image to match apache#3027 * Shading patetrn to match gradle * Fixed/suppressed CVEs * Attempt to fix failing tests in CompactionByEntriesWithMetadataCacheTest Co-authored-by: lushiji <lushiji@didiglobal.com>
5 participants
Motivation
Bringing back maven build as per conversation on ML.
Changes
Reverted change that deleted mvn build, fixed dependencies that were changed after the mvn deletion, suppressed warnings in tests (gradle build seems to ignore the warnings)