update metrics #2999
Merged
update metrics #2999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.Bookie: ReadBytes use entrySize 2.Journal: report journal write error metric 3.LedgerFragmentReplicator: numBytesRead use readBytes
hezhangjian
reviewed
Jan 19, 2022
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieImpl.java
Show resolved
Hide resolved
Member
Author
|
@eolivelli @pkumar-singh @zymap |
nicoloboschi
requested changes
Jan 21, 2022
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerFragmentReplicator.java
Outdated
Show resolved
Hide resolved
zymap
reviewed
Jan 24, 2022
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java
Outdated
Show resolved
Hide resolved
…ournal.java yes,IOException is more appropriate Co-authored-by: Yong Zhang <zhangyong1025.zy@gmail.com>
Member
Author
|
rerun failure checks |
dlg99
approved these changes
Jan 27, 2022
zymap
approved these changes
Feb 15, 2022
StevenLuMT
added a commit
to StevenLuMT/bookkeeper
that referenced
this pull request
Feb 16, 2022
Descriptions of the changes in this PR: ### Motivation some metric's value is not right,so update it the current is problem-driven, and a comprehensive review will be done later. ### Changes update 2 metric: 1.Bookie: ReadBytes use entrySize 2.Journal: report journal write error metric
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
Descriptions of the changes in this PR: ### Motivation some metric's value is not right,so update it the current is problem-driven, and a comprehensive review will be done later. ### Changes update 2 metric: 1.Bookie: ReadBytes use entrySize 2.Journal: report journal write error metric
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Motivation
some metric's value is not right,so update it
the current is problem-driven, and a comprehensive review will be done later.
Changes
update 2 metric:
1.Bookie: ReadBytes use entrySize
2.Journal: report journal write error metric