Skip to content

update metrics #2999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zymap merged 3 commits into from
Feb 15, 2022
Merged

update metrics #2999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
051730a
update 3 metric:
StevenLuMT Jan 19, 2022
9ef5ffd
rollback numBytesRead metric: numBytesRead equal to readableBytes
StevenLuMT Jan 24, 2022
c681483
Update bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/J…
StevenLuMT Jan 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1082,7 +1082,8 @@ public ByteBuf readEntry(long ledgerId, long entryId)
LOG.trace("Reading {}@{}", entryId, ledgerId);
}
ByteBuf entry = handle.readEntry(entryId);
bookieStats.getReadBytes().add(entry.readableBytes());
entrySize = entry.readableBytes();
bookieStats.getReadBytes().add(entrySize);
success = true;
return entry;
} finally {
Expand Down
6 changes: 5 additions & 1 deletion bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,9 +379,9 @@ public int process(boolean shouldForceWrite) throws IOException {
return 0;
}

long startTime = MathUtils.nowInNano();
try {
if (shouldForceWrite) {
long startTime = MathUtils.nowInNano();
this.logFile.forceWrite(false);
journalStats.getJournalSyncStats()
.registerSuccessfulEvent(MathUtils.elapsedNanos(startTime), TimeUnit.NANOSECONDS);
Expand All @@ -397,6 +397,10 @@ public int process(boolean shouldForceWrite) throws IOException {
}

return forceWriteWaiters.size();
} catch (IOException e) {
journalStats.getJournalSyncStats()
.registerFailedEvent(MathUtils.elapsedNanos(startTime), TimeUnit.NANOSECONDS);
throw e;
} finally {
closeFileIfNecessary();
}
Expand Down