Use CSRF headers#430
Merged
asfgit merged 5 commits intoapache:masterfrom Nov 16, 2016
Merged
Conversation
requesting such a header, and if required POST requests fail if it wasn't supplied
ahgittin
force-pushed
the
use-csrf-headers
branch
from
e2a665d to
94e71a8
Compare
now supports AngularJS semantics. also now it doesn't needlessly create sessions.
helps establish csrf protection. done in /server/user and /server/up/extended, the two main places which an interactive app will hit early.
previously `curl /v1/logout` would throw 500 server error
ahgittin
force-pushed
the
use-csrf-headers
branch
from
94e71a8 to
45686e4
Compare
Contributor
|
To the best of my knowledge this looks good, from visual inspection and from test. (A malicious web page posting to the server got the 401 response generated by the CSRF filter.) +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a filter which returns and requires special cookies/headers to protect against forged cross-site requests. Extensive documentation in
CsrfTokenFilter. @neykov or @m4rkmckenna or @geomacy you might be best placed to check this.Also small tidy to logout process in e9aecba -- would be useful if someone familiar with the thinking behind the existing process (switching to user) gives it a quick eyeball (probably @neykov or @bostko ?)